CLDSRV-925: UploadPartCopy handle checksums by leif-scality · Pull Request #6188 · scality/cloudserver

leif-scality · 2026-06-12T16:36:30Z

Handle checksums in UploadPartCopy. Don't compute and store a checksum for parts in external backends (same as PutPart).
fix: CompleteMPU don't require per-part checksums for external backends. UploadPart and UploadPartCopy don't store a checksum for external backend parts so we cannot require them. The final object will not have a checksum.
fix: UploadPart reject Parts missing a COMPOSITE checksum when required
fix: UploadPart returning the default checksum when it should not
fix: CopyObject allow in-place checksum change on self-copy

UploadPartCopy — when the checksum is recomputed vs reused vs skipped

#	MPU algorithm	Dest backend	`copy-source-range` present	Source's stored checksum	Checksum action	Returned in CopyPartResult?
1	none (legacy MPU, pre-feature)	any	any	any	None — nothing stored/returned	–
2	client-provided (explicit) or default (implicit crc64nvme)	external (aws_s3 / azure / gcp / …)	any	any	None — skipped, matches `UploadPart`	no
3	client-provided (explicit) or default (implicit crc64nvme)	local (sproxyd / file / mem)	yes (ranged)	any	Recompute — over the copied range	explicit: yes · default: no (stored only)
4	client-provided (explicit) or default (implicit crc64nvme)	local (sproxyd / file / mem)	no	FULL_OBJECT, same algorithm	Reuse — copy source's stored value	explicit: yes · default: no (stored only)
5	client-provided (explicit) or default (implicit crc64nvme)	local (sproxyd / file / mem)	no	COMPOSITE, different algorithm, or none	Recompute — over the whole part	explicit: yes · default: no (stored only)

bert-e · 2026-06-12T16:36:33Z

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-06-12T16:36:39Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-925 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.4.0

Please check the Fix Version/s of CLDSRV-925, or the target
branch of this pull request.

codecov · 2026-06-12T16:37:04Z

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

claude · 2026-06-15T12:23:11Z

LGTM

Review by Claude Code

claude · 2026-06-18T21:54:39Z

Test names using it() should start with "should" (tests/unit/api/objectCopyPart.js — multiple tests)
- Prefix each test name with "should" (e.g. 'should return true when...')
- Prefer assert.match over assert(err.message.includes(...)) for substring assertions (tests/functional/aws-node-sdk/test/object/mpuUploadPartChecksum.js — lines 136, 247)
- Use assert.match(err.message, /expected checksum Type/) for clearer failure output

Review by Claude Code

…hat forward them

…nds match UploadPart behaviour

… backends

…tests

leif-scality force-pushed the improvement/CLDSRV-925-uploadpartcopy-checksums branch 3 times, most recently from 213b6f9 to c216f9e Compare June 12, 2026 17:13

scality deleted a comment from claude Bot Jun 12, 2026

leif-scality force-pushed the improvement/CLDSRV-925-uploadpartcopy-checksums branch from dc11eca to bb17208 Compare June 18, 2026 21:47

github-advanced-security AI found potential problems Jun 18, 2026

View reviewed changes

Comment thread lib/api/apiUtils/object/sourceChecksum.js

Comment thread lib/api/apiUtils/object/sourceChecksum.js

Comment thread lib/api/objectPutCopyPart.js

claude Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread tests/unit/api/objectCopyPart.js Outdated

claude Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread tests/functional/aws-node-sdk/test/object/mpuUploadPartChecksum.js Outdated

leif-scality force-pushed the improvement/CLDSRV-925-uploadpartcopy-checksums branch from bb17208 to 38b4f47 Compare June 19, 2026 17:09

leif-scality added 4 commits June 19, 2026 23:46

CLDSRV-925: fix UploadPart returns default checksums breaking SDK's t…

4f1c64b

…hat forward them

CLDSRV-925: fix CopyObject allow in-place checksum change on self-copy

d8b98f6

CLDSRV-925: fix reject Parts missing a COMPOSITE checksum when required

0fef152

CLDSRV-925: extract computeChecksumFromDataLocator from CopyObject

2a265f9

leif-scality force-pushed the improvement/CLDSRV-925-uploadpartcopy-checksums branch from c07e840 to 5c07c95 Compare June 19, 2026 21:55

leif-scality added 2 commits June 19, 2026 23:57

CLDSRV-925: add checksum to metadataStorePart

bfeb7ab

CLDSRV-925: UploadPartCopy handle checksums

3d9f7b1

leif-scality added 4 commits June 19, 2026 23:57

CLDSRV-925: UploadPartCopy handle checksums functional tests

ce95c12

CLDSRV-925: UploadPartCopy don't compute checksums for external backe…

f7a9bfb

…nds match UploadPart behaviour

CLDSRV-925: CompleteMPU don't require per-part checksums for external…

ffdfeb8

… backends

CLDSRV-925: fix leaked metadataBackend.deleteObject override in unit …

967cc06

…tests

leif-scality force-pushed the improvement/CLDSRV-925-uploadpartcopy-checksums branch from 5c07c95 to 967cc06 Compare June 19, 2026 22:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLDSRV-925: UploadPartCopy handle checksums#6188

CLDSRV-925: UploadPartCopy handle checksums#6188
leif-scality wants to merge 10 commits into
development/9.4from
improvement/CLDSRV-925-uploadpartcopy-checksums

leif-scality commented Jun 12, 2026 •

edited

Loading

Uh oh!

bert-e commented Jun 12, 2026

Uh oh!

bert-e commented Jun 12, 2026

Uh oh!

codecov Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jun 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claude Bot commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

leif-scality commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

UploadPartCopy — when the checksum is recomputed vs reused vs skipped

Uh oh!

bert-e commented Jun 12, 2026

Hello leif-scality,

Uh oh!

bert-e commented Jun 12, 2026

Incorrect fix version

Uh oh!

codecov Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ JUnit XML file not found

Uh oh!

claude Bot commented Jun 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claude Bot commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leif-scality commented Jun 12, 2026 •

edited

Loading

codecov Bot commented Jun 12, 2026 •

edited

Loading